Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address comments from #3048 #3050

Merged
merged 2 commits into from
Nov 27, 2023

Conversation

lgoettgens
Copy link
Member

#3048 has been merged before the review by @felix-roehrich took place. Here are his suggestions.

Co-authored-by: Felix Röhrich <47457568+felix-roehrich@users.noreply.github.com>
@felix-roehrich
Copy link
Collaborator

Can please update lmul and lmul! while you are at it ?
This should do the trick:

function lmul(x::WeylGroupElem, i::Integer)
  return lmul!(deepcopy(x), i)
end

function lmul!(x::WeylGroupElem, i::Integer)
  @req 1 <= i <= rank(root_system(parent(x))) "Invalid generator"
  _lmul!(parent(x).refl, word(x), UInt8(i))
  return x
end

Then you can remove the comment in ^.

Copy link
Collaborator

@felix-roehrich felix-roehrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link

codecov bot commented Nov 26, 2023

Codecov Report

Merging #3050 (98300db) into master (ba28201) will increase coverage by 0.00%.
The diff coverage is 62.50%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3050   +/-   ##
=======================================
  Coverage   80.43%   80.44%           
=======================================
  Files         520      520           
  Lines       70114    70117    +3     
=======================================
+ Hits        56394    56403    +9     
+ Misses      13720    13714    -6     
Files Coverage Δ
experimental/LieAlgebras/src/RootSystem.jl 41.02% <0.00%> (ø)
experimental/LieAlgebras/src/WeylGroup.jl 78.73% <71.42%> (+3.88%) ⬆️

@lgoettgens
Copy link
Member Author

@simonbrandhorst As you already merged #3048, could you merge this as well?

@thofma thofma enabled auto-merge (squash) November 27, 2023 14:23
@thofma thofma merged commit de7dcdd into oscar-system:master Nov 27, 2023
18 of 22 checks passed
@lgoettgens lgoettgens deleted the lg/root-system-fixes branch November 27, 2023 14:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants