Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup Schemes #3063

Merged
merged 1 commit into from
Dec 1, 2023
Merged

Cleanup Schemes #3063

merged 1 commit into from
Dec 1, 2023

Conversation

simonbrandhorst
Copy link
Collaborator

This moves some helpers out of experimental and deletes two files.

afkafkafk13
afkafkafk13 approved these changes Dec 1, 2023
View reviewed changes
Copy link
Collaborator

@afkafkafk13 afkafkafk13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

This is basically a cleanup of experimental/Schemes/SpecialTypes.jl, in which only some auxilliary routines were left, which should go to the algebraic side anyway.

@simonbrandhorst simonbrandhorst merged commit 0c2b995 into master Dec 1, 2023
16 of 20 checks passed
@simonbrandhorst simonbrandhorst deleted the sb/schemes_cleanup branch December 1, 2023 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afkafkafk13 afkafkafk13 afkafkafk13 approved these changes

@HechtiDerLachs HechtiDerLachs Awaiting requested review from HechtiDerLachs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@simonbrandhorst @afkafkafk13