-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTheoryTools] Yet more improvements #3069
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HereAround
added
optimization
Simpler/more performant code or more/better tests
topic: FTheoryTools
labels
Dec 5, 2023
HereAround
force-pushed
the
NewStuff
branch
6 times, most recently
from
December 6, 2023 13:02
68c7cf3
to
b178d13
Compare
HereAround
force-pushed
the
NewStuff
branch
6 times, most recently
from
December 6, 2023 20:00
d4bb161
to
68e9a2e
Compare
HereAround
force-pushed
the
NewStuff
branch
3 times, most recently
from
December 6, 2023 21:10
c518a56
to
17b1a25
Compare
1. Remove auxiliary toric base space. 2. Extend FamilyOfSpaces to keep support for current functionality.
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3069 +/- ##
==========================================
- Coverage 80.50% 80.49% -0.02%
==========================================
Files 521 522 +1
Lines 70411 70426 +15
==========================================
+ Hits 56683 56688 +5
- Misses 13728 13738 +10
|
apturner
approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the many changes, @HereAround. This looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
optimization
Simpler/more performant code or more/better tests
topic: FTheoryTools
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FamilyOfSpaces
, so that current current functionality remains supported.blow_up
forWeierstrassModels
. This includes introducing the attributeis_partially_resolved
and modifying the corresponding printing. The documentation is updated accordingly.blow_up
ofWeierstrassModels
andGlobalTateModels
do remember all attributes of the original model.