Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] Yet more improvements #3069

Merged
merged 5 commits into from
Dec 8, 2023

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Dec 5, 2023

  • Remove auxiliary toric base space for model constructions over a not fully specified base space.
  • Extend functionality of FamilyOfSpaces, so that current current functionality remains supported.
  • Add function blow_up for WeierstrassModels. This includes introducing the attribute is_partially_resolved and modifying the corresponding printing. The documentation is updated accordingly.
  • blow_up of WeierstrassModels and GlobalTateModels do remember all attributes of the original model.

@HereAround HereAround marked this pull request as draft December 5, 2023 19:16
@HereAround HereAround added optimization Simpler/more performant code or more/better tests topic: FTheoryTools labels Dec 5, 2023
@HereAround HereAround force-pushed the NewStuff branch 6 times, most recently from 68c7cf3 to b178d13 Compare December 6, 2023 13:02
@HereAround HereAround force-pushed the NewStuff branch 6 times, most recently from d4bb161 to 68e9a2e Compare December 6, 2023 20:00
@HereAround HereAround added the enhancement New feature or request label Dec 6, 2023
@HereAround HereAround force-pushed the NewStuff branch 3 times, most recently from c518a56 to 17b1a25 Compare December 6, 2023 21:10
Copy link

codecov bot commented Dec 7, 2023

Codecov Report

Merging #3069 (a6c269b) into master (a5288c1) will decrease coverage by 0.02%.
Report is 8 commits behind head on master.
The diff coverage is 98.76%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3069      +/-   ##
==========================================
- Coverage   80.50%   80.49%   -0.02%     
==========================================
  Files         521      522       +1     
  Lines       70411    70426      +15     
==========================================
+ Hits        56683    56688       +5     
- Misses      13728    13738      +10     
Files Coverage Δ
...ntal/FTheoryTools/src/FamilyOfSpaces/attributes.jl 100.00% <100.00%> (ø)
.../FTheoryTools/src/HypersurfaceModels/attributes.jl 46.15% <ø> (ø)
...TheoryTools/src/HypersurfaceModels/constructors.jl 83.05% <100.00%> (+0.23%) ⬆️
...ental/FTheoryTools/src/LiteratureModels/methods.jl 83.67% <ø> (+20.40%) ⬆️
...rimental/FTheoryTools/src/TateModels/attributes.jl 100.00% <100.00%> (ø)
...mental/FTheoryTools/src/TateModels/constructors.jl 92.75% <100.00%> (+0.64%) ⬆️
...xperimental/FTheoryTools/src/TateModels/methods.jl 51.61% <100.00%> (+0.79%) ⬆️
...rimental/FTheoryTools/src/TateModels/properties.jl 100.00% <ø> (ø)
...l/FTheoryTools/src/WeierstrassModels/attributes.jl 100.00% <100.00%> (ø)
...FTheoryTools/src/WeierstrassModels/constructors.jl 86.95% <100.00%> (+1.04%) ⬆️
... and 6 more

... and 4 files with indirect coverage changes

Copy link
Collaborator

@apturner apturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the many changes, @HereAround. This looks good.

@HereAround HereAround merged commit 32b7e89 into oscar-system:master Dec 8, 2023
18 of 22 checks passed
@HereAround HereAround deleted the NewStuff branch December 8, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Simpler/more performant code or more/better tests topic: FTheoryTools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants