Adv/serialization for multigraded implicitization #3079
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…edImplicitization
…dImplicitization' into adv/serialization-for-MultigradedImplicitization
…edImplicitization
…edImplicitization
…or-MultigradedImplicitization
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3079 +/- ##
===========================================
+ Coverage 63.38% 80.59% +17.20%
===========================================
Files 524 526 +2
Lines 70440 70659 +219
===========================================
+ Hits 44651 56946 +12295
+ Misses 25789 13713 -12076
|
antonydellavecchia
requested review from
ThomasBreuer,
fingolfin and
benlorenz
benlorenz
reviewed
Dec 18, 2023
| @@ -609,7 +609,6 @@ export graded_free_module | |||
| export graded_image | |||
| export graded_map | |||
| export graded_polynomial_ring | |||
| export grading | |||
There was a problem hiding this comment.
Just a note for anyone else looking at this:
We removed the export as this function was broken (it never worked) and also undocumented.
benlorenz
approved these changes
Dec 18, 2023
antonydellavecchia
deleted the
adv/serialization-for-MultigradedImplicitization
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds some functions that help with the setup of parallelization, that will then allow
users to use pmap.
waiting for #3032 to merged before merging this pr.
adds some serialization necessary to setup and run a parallel process for https://github.com/bkholler/MultigradedImplicitization.jl