Fixes sheaf cohomology printing, adds check that coefficient ring is a field #3087
Conversation
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## master #3087 +/- ##
=======================================
Coverage 80.57% 80.58%
=======================================
Files 525 525
Lines 70593 70597 +4
=======================================
+ Hits 56881 56888 +7
+ Misses 13712 13709 -3
|
| elem_type(::FreeMod_dec{T}) where {T} = FreeModElem_dec{T} | ||
| parent_type(::FreeModElem_dec{T}) where {T} = FreeMod_dec{T} |
There was a problem hiding this comment.
Sorry, but I became curious: Where do these types come from and where are they used? I thought that the graded modules are the same as the usual modules. Did anything change there?
There was a problem hiding this comment.
This is beyond my scope to be honest, maybe @jankoboehm knows.
There was a problem hiding this comment.
@HechtiDerLachs Please resolve this in a direct conversation with @jankoboehm
There was a problem hiding this comment.
Don't use for gradings, we plan to use this for filtrations, once they are sorted out for rings.
| elem_type(::FreeMod_dec{T}) where {T} = FreeModElem_dec{T} | ||
| parent_type(::FreeModElem_dec{T}) where {T} = FreeMod_dec{T} |
There was a problem hiding this comment.
Why are those methods necessary? #3068 went to great lengths to remove such methods.
CC: @lgoettgens
Changes as requested in #3084