Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sqrt and cbrt functions for QQAbElem #3096

Merged
merged 3 commits into from
Dec 15, 2023

Conversation

aaruni96
Copy link
Member

Adds sqrt and cbrt functions for QQAbElem. Resolves #3011 .

@thofma
Copy link
Collaborator

thofma commented Dec 12, 2023

roots(a, n) returns a vector, whereas sqrt and cbrt should return a single element. Also tests would be good :)

Copy link

codecov bot commented Dec 14, 2023

Codecov Report

Merging #3096 (177ead3) into master (6d999d6) will increase coverage by 0.00%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3096   +/-   ##
=======================================
  Coverage   80.51%   80.52%           
=======================================
  Files         524      524           
  Lines       70412    70423   +11     
=======================================
+ Hits        56694    56705   +11     
  Misses      13718    13718           
Files Coverage Δ
src/Rings/AbelianClosure.jl 94.87% <100.00%> (+0.09%) ⬆️

... and 3 files with indirect coverage changes

Copy link
Collaborator

@thofma thofma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I suggest two minor changes to the tests to make them more robust (we do not guarantee which root is returned).

May @fieker also wants to have a look?

test/Rings/AbelianClosure.jl Outdated Show resolved Hide resolved
test/Rings/AbelianClosure.jl Outdated Show resolved Hide resolved
@thofma thofma merged commit 4bbbef4 into oscar-system:master Dec 15, 2023
14 of 19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Provide working sqrt for QQAbElem
2 participants