-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[FTheoryTools] More improvements #3097
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HereAround
added
enhancement
New feature or request
optimization
Simpler/more performant code or more/better tests
topic: FTheoryTools
labels
Dec 12, 2023
HereAround
force-pushed
the
NewStuff
branch
7 times, most recently
from
December 12, 2023 22:52
f4a39d9
to
46abbd6
Compare
HereAround
force-pushed
the
NewStuff
branch
4 times, most recently
from
December 13, 2023 14:08
f1fd1ae
to
bfaa0a7
Compare
…erstrass models in our current database
apturner
approved these changes
Dec 18, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for this extensive PR, @HereAround!
Would be great if the commits could be squashed next time. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
enhancement
New feature or request
optimization
Simpler/more performant code or more/better tests
topic: FTheoryTools
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FamilyOfSpaces
,FamilyOfSpaces
,HypersurfaceModels
,LiteratureModels
,index.json
,is_partially_resolved
for hypersurface models (including documentation, test and printing),(More to come...)I guess large enough to stop at this point and address more things in a separate PR.cc @apturner