Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FTheoryTools] More improvements #3097

Merged
merged 11 commits into from
Dec 18, 2023
Merged

Conversation

HereAround
Copy link
Member

@HereAround HereAround commented Dec 12, 2023

  • Document FamilyOfSpaces,
  • Add CI tests for FamilyOfSpaces,
  • Add CI tests for HypersurfaceModels,
  • Add some CI tests for LiteratureModels,
  • Add missing information to Morrison-Park literature models,
  • Correct information in E6, E7, E8 literature models ("Tate form on Steroids"), including update of index.json,
  • Add CI tests which construct all Weierstrass and Tate models currently stored in our database,
  • Add property is_partially_resolved for hypersurface models (including documentation, test and printing),
  • Slight improvements to content of literature model documentation.
  • Fix load error of global Tate models upon saving it to file. Also, restrict this functionality currently to toric bases/ambient spaces only.
  • Test all Tate and Weierstrass literature models also over a concrete base. This allowed me to detect a minor bug, which I fixed.

(More to come...) I guess large enough to stop at this point and address more things in a separate PR.

cc @apturner

@HereAround HereAround marked this pull request as draft December 12, 2023 13:25
@HereAround HereAround added enhancement New feature or request optimization Simpler/more performant code or more/better tests topic: FTheoryTools labels Dec 12, 2023
@HereAround HereAround force-pushed the NewStuff branch 7 times, most recently from f4a39d9 to 46abbd6 Compare December 12, 2023 22:52
@HereAround HereAround marked this pull request as ready for review December 12, 2023 22:53
@HereAround HereAround force-pushed the NewStuff branch 4 times, most recently from f1fd1ae to bfaa0a7 Compare December 13, 2023 14:08
Copy link
Collaborator

@apturner apturner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this extensive PR, @HereAround!

@HereAround HereAround enabled auto-merge (rebase) December 18, 2023 16:57
@HereAround HereAround merged commit 1570785 into oscar-system:master Dec 18, 2023
14 of 19 checks passed
@thofma
Copy link
Collaborator

thofma commented Dec 18, 2023

Would be great if the commits could be squashed next time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request optimization Simpler/more performant code or more/better tests topic: FTheoryTools
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants