Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename groebner_basis(::MPolyQuoRing) #3100

Merged
merged 2 commits into from
Dec 15, 2023
Merged

Rename groebner_basis(::MPolyQuoRing) #3100

merged 2 commits into from
Dec 15, 2023

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Dec 12, 2023 •
edited

Fixes #3086.

@thofma
Copy link
Collaborator Author

thofma commented Dec 13, 2023

@eder I added some comments and also did the same for groebner_basis(I::MPolyQuoRingIdeal), because the return type is not very helpful for a user. It is either true or nothing. I suggest someone cleans this up later, if we want this functionality.

@thofma thofma marked this pull request as ready for review December 13, 2023 17:46
@thofma thofma merged commit 6fedfe7 into master Dec 15, 2023
15 of 20 checks passed
@thofma thofma deleted the th/quoquo branch December 15, 2023 09:55
@thofma thofma mentioned this pull request Feb 4, 2024
Merged
@thofma thofma mentioned this pull request Feb 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ederc ederc ederc approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

groebner_basis(r::MPolyQuoRing) should be renamed
2 participants
@thofma @ederc