Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize BasisLieHighestWeight #3101

Merged
merged 3 commits into from
Jan 5, 2024
Merged

Conversation

gfourier
Copy link
Collaborator

@gfourier gfourier commented Dec 12, 2023

Computing the transpose of sparse matrices has been eleminated from the code at two positions. Further, experiments have shown that using the symmetry of partitions of a dominant weight does not speed up the algorithm in this order, so it is reversed.

@lgoettgens lgoettgens changed the title Gf/optimize Optimize BasisLieHighestWeight Dec 12, 2023
@lgoettgens
Copy link
Member

This PR contains some changes from #3046 as well. Let's try to fix this next time we see each other in the office.

Copy link

codecov bot commented Dec 15, 2023

Codecov Report

Merging #3101 (576d1c0) into master (f7cfd66) will increase coverage by 0.91%.
Report is 43 commits behind head on master.
The diff coverage is 100.00%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3101      +/-   ##
==========================================
+ Coverage   80.55%   81.47%   +0.91%     
==========================================
  Files         525      557      +32     
  Lines       70633    76331    +5698     
==========================================
+ Hits        56899    62188    +5289     
- Misses      13734    14143     +409     
Files Coverage Δ
...erimental/BasisLieHighestWeight/src/LieAlgebras.jl 97.50% <ø> (ø)
...imental/BasisLieHighestWeight/src/MainAlgorithm.jl 97.10% <100.00%> (ø)
...erimental/BasisLieHighestWeight/src/NewMonomial.jl 100.00% <100.00%> (ø)

... and 87 files with indirect coverage changes

@lgoettgens
Copy link
Member

This is ready to get merged.
@thofma could you do the favor?

@lgoettgens lgoettgens closed this Jan 5, 2024
@lgoettgens lgoettgens reopened this Jan 5, 2024
@lgoettgens
Copy link
Member

Bump

@thofma thofma enabled auto-merge (squash) January 5, 2024 14:58
@thofma thofma merged commit 81da0ea into oscar-system:master Jan 5, 2024
38 of 42 checks passed
@lgoettgens lgoettgens deleted the gf/optimize branch February 7, 2024 14:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants