Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conversion bug for PBWAlgQuo elements #3133

Merged
merged 1 commit into from
Dec 30, 2023

Conversation

JohnAAbbott
Copy link
Contributor

Previously got "parents do not match" error; now fixed.

Copy link

codecov bot commented Dec 21, 2023

Codecov Report

Merging #3133 (15afc7c) into master (25af855) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3133   +/-   ##
=======================================
  Coverage   80.61%   80.61%           
=======================================
  Files         529      529           
  Lines       70842    70842           
=======================================
+ Hits        57110    57111    +1     
+ Misses      13732    13731    -1     
Files Coverage Δ
src/Rings/PBWAlgebraQuo.jl 85.98% <100.00%> (+1.86%) ⬆️

... and 2 files with indirect coverage changes

@thofma thofma merged commit 5b4d76a into oscar-system:master Dec 30, 2023
18 of 22 checks passed
paemurru pushed a commit to paemurru/Oscar.jl that referenced this pull request Jan 5, 2024
@JohnAAbbott JohnAAbbott deleted the FixPBWAlgQuo branch January 9, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants