Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use more GAPWrap #3163

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Use more GAPWrap #3163

merged 2 commits into from
Jan 10, 2024

Conversation

lgoettgens
Copy link
Member

No description provided.

@lgoettgens lgoettgens added package: GAP optimization Simpler/more performant code or more/better tests labels Jan 9, 2024
@lgoettgens lgoettgens closed this Jan 9, 2024
@lgoettgens lgoettgens reopened this Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Merging #3163 (5e768c5) into master (499bccb) will increase coverage by 0.06%.
Report is 1 commits behind head on master.
The diff coverage is 95.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3163      +/-   ##
==========================================
+ Coverage   80.86%   80.92%   +0.06%     
==========================================
  Files         550      550              
  Lines       72847    72936      +89     
==========================================
+ Hits        58909    59027     +118     
+ Misses      13938    13909      -29     
Files Coverage Δ
...erimental/BasisLieHighestWeight/src/LieAlgebras.jl 97.50% <100.00%> (ø)
...imental/BasisLieHighestWeight/src/MainAlgorithm.jl 97.10% <100.00%> (ø)
...rimental/BasisLieHighestWeight/src/WeylPolytope.jl 100.00% <100.00%> (ø)
experimental/BasisLieHighestWeight/test/MBOld.jl 97.36% <100.00%> (ø)
experimental/LieAlgebras/src/iso_gap_oscar.jl 100.00% <ø> (ø)
src/GAP/wrappers.jl 96.65% <100.00%> (+0.27%) ⬆️
src/Groups/abelian_aut.jl 97.57% <100.00%> (ø)
src/Groups/cosets.jl 87.17% <100.00%> (ø)
src/Groups/gsets.jl 93.65% <100.00%> (ø)
src/Groups/matrices/forms.jl 93.08% <100.00%> (ø)
... and 3 more

... and 48 files with indirect coverage changes

@fingolfin fingolfin merged commit 6753463 into oscar-system:master Jan 10, 2024
40 of 42 checks passed
@lgoettgens lgoettgens deleted the lg/GAP.Globals branch January 10, 2024 06:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
optimization Simpler/more performant code or more/better tests package: GAP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants