add normalize_with_delta #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The keyword argument names ( Also, according to codecov there are some untested branches. |
|
There is something wrong with coverage generated by |
|
There is no |
fingolfin
approved these changes
Mar 16, 2021
| end | ||
|
|
||
| @doc Markdown.doc""" | ||
|
|
There was a problem hiding this comment.
Suggested change
| normalize_with_delta(A::MPolyQuo; alg=:equidimDec) | |
test/Rings/MPolyQuo.jl
Outdated
| for algorithm in (:equidimDec, :primeDec) | ||
| R, (x, y, z) = PolynomialRing(QQ, ["x", "y", "z"]) | ||
| Q, _ = quo(R, ideal(R, [(x^2 - y^3)*(x^2 + y^2)*x])) | ||
| for (S, M, FI) in normalize(Q) |
There was a problem hiding this comment.
Perhaps this was meant? (I can't test it right now)
Suggested change
| for (S, M, FI) in normalize(Q) | |
| for (S, M, FI) in normalize(Q; alg=algorithm) |
test/Rings/MPolyQuo.jl
Outdated
| @test parent(M(Q(x+y))) == S | ||
| end | ||
|
|
||
| stuff, deltas, tot_delta = normalize_with_delta(Q) |
There was a problem hiding this comment.
Maybe this?
Suggested change
| stuff, deltas, tot_delta = normalize_with_delta(Q) | |
| stuff, deltas, tot_delta = normalize_with_delta(Q; alg=algorithm) |
|
Sorry all, It should be better now. |
|
I'll merge it after the tests... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.