Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ep/ Rename Spec to AffineScheme #3345 #3425

Merged
merged 29 commits into from
Feb 26, 2024
Merged

Ep/ Rename Spec to AffineScheme #3345 #3425

merged 29 commits into from
Feb 26, 2024

Commits on Feb 23, 2024

  1. Rename Spec -> AffineScheme

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    741bd5d View commit details
    Browse the repository at this point in the history

  2. Fix missed Spec -> AffineScheme

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5cceb01 View commit details
    Browse the repository at this point in the history

  3. Fix: rename one more Spec to AffineScheme

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    aacac2e View commit details
    Browse the repository at this point in the history

  4. Fix: change three more Spec's to AffineScheme

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    9b7ba2f View commit details
    Browse the repository at this point in the history

  5. Rename the function AffineScheme to spec 

    Use `AffineScheme` only for the type, not the function.
    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    7ea5a43 View commit details
    Browse the repository at this point in the history

  6. Rename proj for toric divisors to projectivization 

    As was recommended by Martin Bies and Wolfram Decker.
    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    400fc1e View commit details
    Browse the repository at this point in the history

  7. Change non-scheme proj functions to something else 

    For biproducts, naming the output triple
    [obj], inj, pr
seems to be common. Among the changes was changing "proj" to "pr" in the
triples
    [obj], inj, proj
    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    cb13aad View commit details
    Browse the repository at this point in the history

  8. Function ProjectiveScheme to projective_scheme 

    Also some other minor fixes
    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b4c5989 View commit details
    Browse the repository at this point in the history

  9. Fix: spec now extends the constructor AffineScheme 

    In particular, spec allows the argument to be a quotient ring or localized ring. Similarly for proj. Probably the tests would not have passed in the previous commit because of this
    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    587ceeb View commit details
    Browse the repository at this point in the history

  10. rename filename

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    b30d8c9 View commit details
    Browse the repository at this point in the history

  11. Fix tests for proj

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    32c2c30 View commit details
    Browse the repository at this point in the history

  12. projecitve_scheme -> proj

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1110b7f View commit details
    Browse the repository at this point in the history

  13. Add checks for being standard graded

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    8839c79 View commit details
    Browse the repository at this point in the history

  14. Remove possibly redundant proj function 

    proj(Q::MPolyQuoRing{MPolyDecRingElem{T, PT}}) where {T, PT<:MPolyRingElem{T}} = ProjectiveScheme(Q)
    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    35b8209 View commit details
    Browse the repository at this point in the history

  15. Fix docs

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    c23e8ca View commit details
    Browse the repository at this point in the history

  16. Fix duplicate exports entry

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d41795a View commit details
    Browse the repository at this point in the history

  17. Use script to rename all other functions and types

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    0247d48 View commit details
    Browse the repository at this point in the history

  18. Fix sorting script, sort src/exports.jl

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1a227b4 View commit details
    Browse the repository at this point in the history

  19. Rename two test files

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    f313e20 View commit details
    Browse the repository at this point in the history

  20. Merge branch 'oscar-system:master' into EP/RenameSpecToAffineScheme

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    5fd8b4c View commit details
    Browse the repository at this point in the history

  21. Fix symbolic link

    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    1b31ab0 View commit details
    Browse the repository at this point in the history

  22. Strange biproduct order in hermitian_miranda_morrison.jl 

    Remove commented question that I made earlier. Better to make an issue or ask someone than comment the code.
    @paemurru
    paemurru committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    6b2d4f7 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Merge branch 'oscar-system:master' into EP/RenameSpecToAffineScheme

    @paemurru
    paemurru committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    a4f6269 View commit details
    Browse the repository at this point in the history

  2. Undo everything in cb13aad except projectivization

    @paemurru
    paemurru committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    8b7dc97 View commit details
    Browse the repository at this point in the history

  3. Fix one forgotten proj from last commit

    @paemurru
    paemurru committed Feb 25, 2024
    Configuration menu
    Copy the full SHA
    d52731f View commit details
    Browse the repository at this point in the history

Commits on Feb 26, 2024

  1. Apply suggestions from code review

    @simonbrandhorst
    simonbrandhorst committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    70c527f View commit details
    Browse the repository at this point in the history

  2. add support for projective_scheme and affine_scheme

    @simonbrandhorst
    simonbrandhorst committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    501ad23 View commit details
    Browse the repository at this point in the history

  3. fix typo

    @simonbrandhorst
    simonbrandhorst committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    532a47e View commit details
    Browse the repository at this point in the history

  4. fix typo

    @simonbrandhorst
    simonbrandhorst committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    32404e0 View commit details
    Browse the repository at this point in the history