Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

for issue #3488 -- avoid corruption of internal ideal data #3536

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

afkafkafk13
Copy link
Collaborator

#3488 is due to inheriting internal data in a corner case in src/Rings/mpoly-affine-algebras.jl.
This is a workaround avoiding corruption by forcing creation of a new object.

@joschmitt joschmitt linked an issue Mar 20, 2024 that may be closed by this pull request
Copy link
Member

@joschmitt joschmitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took me a moment to understand what's going on here... apparently the Singular polynomial rings are always cached (independent of the cached keyword) except if they are not... If this works, it works.

@afkafkafk13 afkafkafk13 merged commit 1678b0d into oscar-system:master Mar 21, 2024
23 checks passed
@afkafkafk13 afkafkafk13 deleted the normalization-bug branch March 27, 2024 20:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Normalization returns a corrupted ring
2 participants