Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add absolute_primary_decomposition over QQ #472

Merged

Conversation

tthsqe12
Copy link
Contributor

@thofma
Copy link
Collaborator

thofma commented Jun 14, 2021

Was there a decision to not do a proper field extension but the "additional variable" hack?

@tthsqe12
Copy link
Contributor Author

What? We decided to do the proper field extension...

@thofma
Copy link
Collaborator

thofma commented Jun 14, 2021

I misread a comment in the source code code. Ignore my remark.

@thofma thofma merged commit 6731cc4 into oscar-system:master Jun 14, 2021
@wdecker
Copy link
Collaborator

wdecker commented Jun 14, 2021

@tthsqe12: Thanks!

@tthsqe12 tthsqe12 deleted the add_absolute_primary_decomposition branch July 19, 2021 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants