Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nmod ring #528

Merged
merged 2 commits into from
Jul 15, 2021
Merged

Fix nmod ring #528

merged 2 commits into from
Jul 15, 2021

Conversation

tthsqe12
Copy link
Contributor

@tthsqe12 tthsqe12 commented Jul 5, 2021 •
edited
Loading

Will eventually fix #444
This is a bit difficult because a proper solution requires singular's multiprecision Z/nZ coeffs.
@wdecker @hannes14 I noticed singular's gb engine crashing with (integer, 269484097) coeffs instead of the usual F_269484097 coeffs. Not sure whose fault it is at this point.
Also, @thofma there is a strange hecke bug in the test code that I added.
here is MWE

using Oscar
R,(x,y) = PolynomialRing(ResidueRing(ZZ, ZZ(10)^50+151), ["x", "y"])
divrem(x+y,y)

@thofma
Copy link
Collaborator

thofma commented Jul 6, 2021

The Hecke bug will be fixed by thofma/Hecke.jl#332.

@tthsqe12 tthsqe12 closed this Jul 15, 2021
@tthsqe12 tthsqe12 reopened this Jul 15, 2021
@thofma thofma mentioned this pull request Jul 15, 2021
Closed
@tthsqe12 tthsqe12 changed the title [WIP hold at least until next Singular.jl ring] Fix nmod ring Fix nmod ring Jul 15, 2021
@tthsqe12
Copy link
Contributor Author

@thofma This seems fine by me, so please merge if you agree with the changes.

@thofma thofma merged commit fa25f4d into oscar-system:master Jul 15, 2021
@tthsqe12 tthsqe12 deleted the fix_nmod_ring branch July 4, 2022 09:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Don't forget to fix singular_ring(::NmodRing)
2 participants
@tthsqe12 @thofma