-
Notifications
You must be signed in to change notification settings - Fork 113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
some more docu for invariant theory #599
Merged
Changes from 2 commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The notation
K[x]^G
to me always indicates a right action, i.e. a mapSET x GROUP -> SET
. That would suggest writing\pi ^ f = f
. This would be consistent with our plan to do everything in Oscar based on right actions, like it is done in GAP and in MAGMA. Indeed, MAGMA even does this in invariant theory, see:K[V]^g
f
, a matrixg
and a coordinate vectorx
, they definef^g(x) := f(x.g)
, which is indeed a right action. Translated to the notation used above:f^\pi(v) = f(v \rho(\pi))
This is in contrast to the action described above in line 22/23, which is a left action (and has to invert or transpose the acting matrix to achieve that).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually, the action Magma describes is a left action after all... Now I am confused what they do, I will check with actual code.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For what it's worth, I think finvar.lib in Singular does right actions. So the matrix M =
( a b )
( c d )
acts on K[x, y] by mapping x to ax + by and y to cx + dy. At least I would call this a right action because I would identify x with the vector (1 0) and then (1 0)*M is (a b), so the matrix acts "from the right".
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The hallmark of a right action is it must satisfy
(f^a)^b = f^{a*b}
while for a left action it isa*(b*f) = (a*b)*f
(or, if one uses the notation for right actions to write down a left action, one gets(f^a)^b = f^{b*a}
. So, just take two matrices a,b that do not commute and compare (f^a)^band
f^{ab}`.So that's what one should check for the Singular computations.
As to Magma, I verified they do implement a right action on polynomials via the above rules:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not quite as easy to reproduce this in Singular / finvar.lib, because the action of a matrix on a polynomial is just not implemented. Doing the action by hand as in
evaluate_reynolds()
for example the results are exactly as in Magma.