Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix type instability in number_moved_points #670

Merged
merged 1 commit into from
Sep 8, 2021
Merged

Fix type instability in number_moved_points #670

merged 1 commit into from
Sep 8, 2021

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Sep 8, 2021

Closes #666.

ThomasBreuer
ThomasBreuer approved these changes Sep 8, 2021
View reviewed changes
Copy link
Member

@ThomasBreuer ThomasBreuer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.
(There are more instances of this problem in the Groups code. I am going to deal with them.)

@thofma thofma merged commit 0cd2b06 into master Sep 8, 2021
@fingolfin fingolfin deleted the th/nmp branch September 15, 2021 13:33
fieker pushed a commit that referenced this pull request Sep 30, 2021
@thofma @fieker
Fix type instability in number_moved_points (#670)
726222f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ThomasBreuer ThomasBreuer ThomasBreuer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

number_moved_points does not know that it returns fmpz
2 participants
@thofma @ThomasBreuer