fixed QabElem, improved printing of char. tables
#752
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- fixed `QabElem` for GAP cyclotomics: We have to use the cyclotomic fields that are cached in `abelian_closure(QQ)`, otherwise the elements created by `QabElem` will not be compatible. - fixed the printing of cyclotomics in Julia: The correct cyclotomic fields cause a different `string` format for elements. - In `show` for character tables, if the irrational values are shown via symbolic names then use `*` to denote algebraic conjugacy in quadratic fields (relative names like `X` and `X*`). - Use `"text/latex"` not `"text/html"` to specify that one wants LaTeX format.
fingolfin
reviewed
Oct 22, 2021
fingolfin
reviewed
Oct 22, 2021
fingolfin
reviewed
Oct 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixed
QabElemfor GAP cyclotomics:We have to use the cyclotomic fields that are cached in
abelian_closure(QQ), otherwise the elements created byQabElemwill not be compatible.fixed the printing of cyclotomics in Julia:
The correct cyclotomic fields cause a different
stringformat for elements.In
showfor character tables, if the irrational values are shown viasymbolic names then use
*to denote algebraic conjugacy in quadratic fields(relative names like
XandX*).Use
"text/latex"not"text/html"to specify that one wants LaTeX format.