fix for ring_iso_oscar_gap
#799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
... for certain finite fields The changes are just a workaround for a GAP bug, see gap-system/gap/issues/4694.
fingolfin
approved these changes
Nov 11, 2021
| if GAP.Globals.IsAlgebraicExtension(G) | ||
| #FIXME: | ||
| # As soon as the problem from https://github.com/gap-system/gap/issues/4694 | ||
| # is fixed, go back to `Basis_G = GAP.Globals.Basis(G)` also in this case. |
There was a problem hiding this comment.
We probably should do more, though, and try to actively avoid this case, e.g. by checking if the Oscar polynomial is a Conway polynomial, in which case we can just use GAP.Globals.GF(GAP.Obj(p),d) instead of GAP.Globals.GF(Fp_gap, f_gap).
There was a problem hiding this comment.
Yes, but this is independent of the current workaround.
I can create a pull request for this improvement.
|
@fieker this should resolved your conversion issues for matrices over fields with "large" characteristic. |
fingolfin
pushed a commit
that referenced
this pull request
Nov 12, 2021
As suggested by @fingolfin in a comment to #799: On the GAP side, choose a field that is not in `GAP.Globals.IsAlgebraicExtension` if the given field is defined by a Conway polynomial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
... for certain finite fields.
The changes are just a workaround for a GAP bug,
see gap-system/gap/issues/4694.