Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #795 #811

Merged
merged 1 commit into from
Nov 12, 2021
Merged

Fixes #795 #811

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion experimental/ModStd/ModStdQ.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,7 @@ end
function Oscar.groebner_basis_with_transform(I::MPolyIdeal{fmpq_mpoly}; ordering::Symbol = :degrevlex, complete_reduction::Bool = true, use_hilbert::Bool = false)

if iszero(I)
I.gb = BiPolyArray(base_ring(I), fmpq_mpoly[], isGB = true)
I.gb = BiPolyArray(base_ring(I), fmpq_mpoly[], isGB = true, keep_ordering = false)
singular_assure(I.gb)
return fmpq_mpoly[], matrix(base_ring(I), ngens(I), 0, fmpq_mpoly[])
end
Expand Down
1 change: 1 addition & 0 deletions src/Rings/mpoly-ideals.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -804,6 +804,7 @@ false
```
"""
function Base.:(==)(I::MPolyIdeal, J::MPolyIdeal)
I === J && return true
return issubset(I, J) && issubset(J, I)
end

Expand Down
7 changes: 7 additions & 0 deletions test/Rings/mpoly-test.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -260,3 +260,10 @@ end
end
@test Q == I
end

@testset "#795" begin
R, = QQ["x", "y"]
I = ideal(R, zero(R))
@test issubset(I, I)
@test I == I
end