Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to latest Polymake.jl, Singular.jl #93

Merged
merged 1 commit into from
Apr 25, 2020

Conversation

fingolfin
Copy link
Member

These two new versions use CxxWrap 0.10.1. which hopefully will resolve the issue @wdecker was seeing.

GAP.jl still needs to be updated, but I don't know how to find the time given teaching duties and having a 3 year old kid, and no support from the university with that.

@fingolfin fingolfin requested a review from fieker April 23, 2020 09:26
Copy link
Contributor

@fieker fieker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

finally!!!

@fingolfin
Copy link
Member Author

See here:

@codecov
Copy link

codecov bot commented Apr 24, 2020

Codecov Report

Merging #93 into master will decrease coverage by 1.50%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master      #93      +/-   ##
==========================================
- Coverage   13.87%   12.37%   -1.51%     
==========================================
  Files           7        7              
  Lines        1456     1641     +185     
==========================================
+ Hits          202      203       +1     
- Misses       1254     1438     +184     
Impacted Files Coverage Δ
src/Rings/mpoly.jl 30.74% <0.00%> (-5.65%) ⬇️
src/Polymake/Ineq.jl 37.83% <0.00%> (-1.60%) ⬇️
src/Oscar.jl 7.69% <0.00%> (-1.40%) ⬇️
src/Polymake/NmbThy.jl 46.15% <0.00%> (-0.34%) ⬇️
src/Rings/mpoly-graded.jl 0.00% <0.00%> (ø)
src/Modules/FreeModules-graded.jl 0.00% <0.00%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants