Add promotion rules for fmpz -> Singular types #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I don't have any objections, if the test cases do actually trigger those promote_rules. |
|
Actually, not all are covered yet (Codecov report reveals this). I'll fix that. |
fingolfin
force-pushed
the
mh/promote_rules
branch
from
9671e6b
to
da55be5
Compare
|
OK, I extended the tests and made them more systematic. Let's see if that covered all the new rules (once the Codecov report is in) |
Mostly for conveniences in code which works directly with Singular.jl objects. Also extend the tests for adhoc arithmetic / promotion rules
fingolfin
force-pushed
the
mh/promote_rules
branch
from
da55be5
to
ccb25a4
Compare
|
On https://codecov.io/gh/oscar-system/Singular.jl/pull/364 one can verify that all the new promotion rules are triggered (plus some more code which wasn't covered before) |
wbhart
approved these changes
Jan 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly for conveniences in code which works directly with Singular.jl objects.
Honestly, I am not sure if this is a good idea or a really bad one... Wonder if @wbhart or @fieker have any thoughts about this (I'll have no hard feelings if this is not merged; but it was useful for me to learn more about the AA/Nemo promotion system ;-) ).