Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix some ad hoc binary methods #461

Merged
merged 1 commit into from Jul 14, 2021
Merged

Fix some ad hoc binary methods #461

merged 1 commit into from Jul 14, 2021

Conversation

thofma
Copy link
Collaborator

@thofma thofma commented Jul 14, 2021 •
edited

Closes #459

@thofma thofma requested a review from tthsqe12 July 14, 2021 15:50
tthsqe12
tthsqe12 approved these changes Jul 14, 2021
View reviewed changes
Copy link
Contributor

@tthsqe12 tthsqe12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is fine. I like the comments increasing the bus factor.

@thofma thofma merged commit 0b497f0 into master Jul 14, 2021
@fingolfin fingolfin deleted the th/fakepromote branch October 19, 2021 21:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tthsqe12 tthsqe12 tthsqe12 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Broken promotions
2 participants
@thofma @tthsqe12