Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CompatHelper: bump compat for CxxWrap to 0.12, (keep existing compat) #536

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Jan 7, 2022

This pull request changes the compat entry for the CxxWrap package from 0.11 to 0.11, 0.12.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@thofma
Copy link
Collaborator

thofma commented Jan 7, 2022

Do we need to rebuild libsingular_julia to use that? @fingolfin @tthsqe12?

@fingolfin
Copy link
Member

Good question. "It depends", I guess, what the changes are in CxxWrap / libcxxwrap and if they are fully binary compatible with what we do or not... But if we do need a rebuild, then I guess we'll also have to drop the older CxxWrap versions?

Perhaps we need to ask @barch what really changed?

See also oscar-system/Polymake.jl#383 (CC @benlorenz)

@thofma
Copy link
Collaborator

thofma commented Jan 18, 2022

@benlorenz is it safe to just update?

@benlorenz
Copy link
Member

It should be safe, Polymake.jl seems to be running fine with the latest version.

Both with new binaries built against the new libcxxwrap and with the old binaries that were built with the older version:
The latest release of Polymake.jl accepts both 0.11 and 0.12, in the Oscar tests 0.11 is used because of the Singular compat and the Polymake tests run fine with 0.12.

But we should at least run the tests here, why don't they run for this PR?

@thofma
Copy link
Collaborator

thofma commented Jan 18, 2022

Thanks for the feedback. We had an old *.yml file, which did not include the hack to make it trigger CI.

@thofma thofma merged commit 9127347 into master Jan 18, 2022
@fingolfin fingolfin deleted the compathelper/new_version/2022-01-07-00-10-00-677-04213400933 branch March 6, 2022 21:51
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants