Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Var index #88

Merged
merged 7 commits into from
Feb 14, 2019
Merged

Var index #88

merged 7 commits into from
Feb 14, 2019

Conversation

wbhart
Copy link
Contributor

@wbhart wbhart commented Feb 4, 2019

Adds var_index function. Will not work until new version of AbstractAlgebra.

@codecov
Copy link

codecov bot commented Feb 4, 2019

Codecov Report

Merging #88 into master will increase coverage by 0.23%.
The diff coverage is 66.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #88      +/-   ##
==========================================
+ Coverage   46.59%   46.83%   +0.23%     
==========================================
  Files          30       30              
  Lines        2410     2434      +24     
==========================================
+ Hits         1123     1140      +17     
- Misses       1287     1294       +7
Impacted Files Coverage Δ
src/ideal/IdealTypes.jl 73.68% <ø> (ø) ⬆️
src/Singular.jl 90.47% <ø> (ø) ⬆️
src/matrix/MatrixTypes.jl 91.66% <ø> (ø) ⬆️
src/resolution/ResolutionTypes.jl 100% <ø> (ø) ⬆️
src/module/ModuleTypes.jl 78.12% <ø> (ø) ⬆️
src/module/module.jl 59.64% <100%> (ø) ⬆️
src/ideal/ideal.jl 77.16% <50%> (ø) ⬆️
src/poly/poly.jl 68.22% <65.47%> (+0.21%) ⬆️
src/poly/PolyTypes.jl 54.54% <83.33%> (ø) ⬆️
src/module/vector.jl 85.29% <0%> (ø) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c80a6cb...38fd771. Read the comment docs.

@wbhart
Copy link
Contributor Author

wbhart commented Feb 12, 2019

This PR is ready to go now, @hannes14 @steenpass

@steenpass steenpass merged commit 585b0aa into oscar-system:master Feb 14, 2019
fingolfin pushed a commit to fingolfin/Singular.jl that referenced this pull request Jun 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants