Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Initial version #1

Merged
merged 14 commits into from
Jun 2, 2021
Merged

feat: Initial version #1

merged 14 commits into from
Jun 2, 2021

Conversation

oscard0m
Copy link
Owner

@oscard0m oscard0m commented Jun 1, 2021

Your new script is ready to be implemented 🎉

You can run it locally on your machine with

node cli.js

Once you are happy with it, push your changes to this pull request

git commit -a -m "feat: initial version"
git push

Before merging:


View rendered README.md

@gr2m
Copy link

gr2m commented Jun 1, 2021

probably not a bug with your script but with Octoherd, but I was surprised to see the msg option in the PATCH /repos/{owner}/{repo} request

image

Update: also where does the name parameter come from?

@gr2m
Copy link

gr2m commented Jun 1, 2021

no need to do this as part of the initial version, but maybe create issues for later:

@oscard0m
Copy link
Owner Author

oscard0m commented Jun 2, 2021

Update: also where does the name parameter come from?

https://docs.github.com/en/rest/reference/repos#update-a-repository seems that the docs are duplicating the parameter (repo and name)? @gr2m

@oscard0m
Copy link
Owner Author

oscard0m commented Jun 2, 2021

probably not a bug with your script but with Octoherd, but I was surprised to see the msg option in the PATCH /repos/{owner}/{repo} request

image

Follow up as a discussion here before opening an issue: octoherd/octoherd#23

@oscard0m oscard0m merged commit 2cf5c0a into main Jun 2, 2021
@oscard0m oscard0m deleted the initial-version branch June 2, 2021 10:01
@github-actions
Copy link

github-actions bot commented Jun 2, 2021

🎉 This PR is included in version 1.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gr2m
Copy link

gr2m commented Jun 2, 2021

https://docs.github.com/en/rest/reference/repos#update-a-repository seems that the docs are duplicating the parameter (repo and name)? @gr2m

You can use name to change the name of the repository. repo is the current name

@oscard0m
Copy link
Owner Author

oscard0m commented Jun 2, 2021

https://docs.github.com/en/rest/reference/repos#update-a-repository seems that the docs are duplicating the parameter (repo and name)? @gr2m

You can use name to change the name of the repository. repo is the current name

Ohhh I see, I didn't know that name parameter was used for renaming. I'm going to remove it from this script then. Thanks! 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants