Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't scroll parent window when focused on editor #56

Closed
OscarGodson opened this issue Mar 13, 2012 · 2 comments
Closed

Don't scroll parent window when focused on editor #56

OscarGodson opened this issue Mar 13, 2012 · 2 comments
Labels
Milestone

Comments

@OscarGodson
Copy link
Owner

Lets say you're scrolling through a large MD file, once you hit the bottom the entire page will start scrolling, not just the iframe. AFAIK you can't prevent scrolling, however, you can add a document.body.overflow = 'hidden' and it will make the page not scrollable.

We'll wanna probably see if it looks ok to do that, but this will make it so as long as you're focused on the editor (mouse hovering, or click inside the iframe) you can't start to scroll down the parent document.

@ghost ghost assigned dadambickford Mar 13, 2012
@OscarGodson
Copy link
Owner Author

I was thinking about this again today and checking for scrolling wont work because once you hit the bottom the scrolling stops therefore it'll start scrolling the parent again. You'll probably instead want to prevent scrolling while focused on the editor or something.

@OscarGodson
Copy link
Owner Author

Going to close this for now. No other editors do this and because of that would probably be bad UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants