Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim tab characters from comment lines #215

Merged
merged 2 commits into from Jul 15, 2019
Merged

Trim tab characters from comment lines #215

merged 2 commits into from Jul 15, 2019

Conversation

ocean90
Copy link
Contributor

@ocean90 ocean90 commented Jul 12, 2019

Related report: wp-cli/i18n-command#169

When a PHP comment is indented with a tab character it currently doesn't get extracted. Adding the tab to the characters to strip will fix this.

@ocean90 ocean90 mentioned this pull request Jul 12, 2019
Merged
@swissspidy
Copy link
Contributor

Looks like this breaks Gettext\Tests\AssetsTest::testTwig twig/Po as the line numbers change. Haven't checked whether the assertions were actually wrong or if this is a regression.

@ocean90
Copy link
Contributor Author

ocean90 commented Jul 12, 2019

@swissspidy Those are unrelated based on the build status of the master branch.

@swissspidy
Copy link
Contributor

Ah yes, indeed! 👍

@ocean90
Copy link
Contributor Author

ocean90 commented Jul 13, 2019

#216 updates the incorrect line numbers.

@oscarotero oscarotero merged commit 81933e3 into php-gettext:master Jul 15, 2019
@oscarotero
Copy link
Member

Thanks 👍

@ocean90 ocean90 deleted the patch-1 branch July 15, 2019 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swissspidy swissspidy swissspidy approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ocean90 @swissspidy @oscarotero