Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test to cover translator comments with tab indentations #170

Merged
merged 6 commits into from Jul 15, 2019
Merged

Add test to cover translator comments with tab indentations #170

merged 6 commits into from Jul 15, 2019

Conversation

ocean90
Copy link
Contributor

@ocean90 ocean90 commented Jul 12, 2019

Fixes #169.

The test will pass with the fix from php-gettext/Gettext#215.

@ocean90 ocean90 requested a review from a team as a code owner July 12, 2019 15:26
features/makepot.feature Outdated Show resolved Hide resolved
features/makepot.feature Outdated Show resolved Hide resolved
Co-Authored-By: Alain Schlesser <alain.schlesser@gmail.com>
@swissspidy
Copy link
Member

@schlessera Are you fine with referencing dev-master#68d9f76f709a12ad7c3159d0acb08f9cad159426 of the upstream library directly, or should we wait for a release?

@ocean90
Copy link
Contributor Author

ocean90 commented Jul 15, 2019

The reference should be just for testing, we should wait for the release. The current way generates a warning during composer validate and composer install.

  - Installing gettext/gettext (dev-master 68d9f76): Cloning 68d9f76f70 from cache
    68d9f76f709a12ad7c3159d0acb08f9cad159426 is gone (history was rewritten?)
    Failed to download gettext/gettext from source: Failed to execute git checkout '68d9f76f709a12ad7c3159d0acb08f9cad159426' -- && git reset --hard '68d9f76f709a12ad7c3159d0acb08f9cad159426' --
fatal: reference is not a tree: 68d9f76f709a12ad7c3159d0acb08f9cad159426
    Now trying to download from dist
  - Installing gettext/gettext (dev-master 68d9f76): Loading from cache

@schlessera
Copy link
Member

I'm fine with referencing the specific commit, provided that we add corresponding issues to make sure we don't forget to change it back to a release again later.

@swissspidy
Copy link
Member

Version 4.6.3 of the gettext library was just released.

@ocean90 Would you mind updating your PR? Thanks!

@swissspidy swissspidy merged commit 09c32cd into wp-cli:master Jul 15, 2019
@ocean90 ocean90 deleted the add/test-comments-with-tab-indentation branch July 15, 2019 15:09
schlessera pushed a commit that referenced this pull request Jan 6, 2022
…tation

Add test to cover translator comments with tab indentations
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Translator comments are not extracted when PHP comment starts with a tab character
3 participants