Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding url crate support #84

Merged
merged 3 commits into from May 30, 2023

Conversation

tonymushah
Copy link
Contributor

@tonymushah tonymushah commented May 29, 2023

this will add the URL crate support for specta
ref : #83
I just added an
#[cfg(feature = "url")] impl_as!( url::Url as String );
in src\type\impls.rs

i'm not sure if it work on export tougth

tests/ts_rs/url.rs Outdated Show resolved Hide resolved
Copy link
Collaborator

@Brendonovich Brendonovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We probably should have supported url from the start 😅

@tonymushah
Copy link
Contributor Author

We probably should have supported url from the start 😅

Yes, url is already supported by specta

More details there

Copy link
Collaborator

@Brendonovich Brendonovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wouldn't call #[specta(type = String)] 'support' for url, more just a workaround. This is much better!

@Brendonovich Brendonovich merged commit d2fa990 into oscartbeaumont:main May 30, 2023
@tonymushah tonymushah deleted the adding-url-support branch May 30, 2023 17:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants