Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a default case for "I don't know that command" #53

Closed
daemon1024 opened this issue Nov 6, 2020 · 4 comments · Fixed by #55
Closed

Add a default case for "I don't know that command" #53

daemon1024 opened this issue Nov 6, 2020 · 4 comments · Fixed by #55
Assignees
Labels
discord bot enhancement New feature or request good first issue Good for newcomers

Comments

@daemon1024
Copy link
Member

daemon1024 commented Nov 6, 2020

New feature

Currently the discord bot doesn't respond to unknown triggers, but it should let the user know about the command being invalid.

Directions/Approach

https://github.com/osdc/bots/blob/6adc0b2cdd6b3258dfc32376272901e3cb5c1585/discord-bot/bot.js Add an else case. May need to convert the existing if statements to else if.

First-time Contributors

If it is the first time that you contribute to the bot, follow these steps:

Write a comment in this issue thread to let other possible contributors know that you are working on this bug. For eg : Hey all, I would like to work on this issue., follow README to the bot 🔥✨ and feel free to ask anything related to this issue ✌️

@daemon1024 daemon1024 added enhancement New feature or request good first issue Good for newcomers discord bot labels Nov 6, 2020
@daemon1024 daemon1024 added this to To do in osdc-discord-bot via automation Nov 6, 2020
@reapedjuggler
Copy link
Contributor

Hey folks ! I would like to work on this issue

@daemon1024
Copy link
Member Author

@reapedjuggler Great 🚀. Thanks for showing your interest in this 🎉. I have assigned it to you 😁. Feel free to ask any queries regarding the issue or setting up the bot ✌️.

@PrimalPimmy
Copy link
Member

Just a suggestion, it should be more like "I don't know this command, do !help to see the list of commands."

@reapedjuggler
Copy link
Contributor

Just a suggestion, it should be more like "I don't know this command, do !help to see the list of commands."

Yes I will keep in mind :D

reapedjuggler added a commit to reapedjuggler/bots that referenced this issue Nov 8, 2020
Issue osdc#53 ,Bot was not showing any response for unknown triggers. Fixed it by adding a default message whenever a invalid command is triggered.
reapedjuggler added a commit to reapedjuggler/bots that referenced this issue Nov 8, 2020
Issue osdc#53, Bot was not showing any response for unknown triggers. Fixed it by adding a default message whenever a invalid command is triggered.
osdc-discord-bot automation moved this from To do to Done Nov 10, 2020
sidntrivedi012 pushed a commit that referenced this issue Nov 10, 2020
* Update bot.js

Added a default message for the commands which aren't valid

* Added a default message for the invalid commands #53

Issue #53 ,Bot was not showing any response for unknown triggers. Fixed it by adding a default message whenever a invalid command is triggered.

* Bot not responding to unknown Commands #53

Issue #53, Bot was not showing any response for unknown triggers. Fixed it by adding a default message whenever a invalid command is triggered.

* Update bot.js

* Removed unwanted return statement
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discord bot enhancement New feature or request good first issue Good for newcomers
Projects
Development

Successfully merging a pull request may close this issue.

3 participants