Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Downloading OneDriveSetup.exe with the WebClient doesn't work correctly #71

Open
NKK80 opened this issue Jan 11, 2022 · 5 comments
Open
Assignees
Labels
bug Something isn't working

Comments

@NKK80
Copy link

NKK80 commented Jan 11, 2022

The variables on row 280 of Save-OSDBuilderDownload.ps1 are empty when PowerShell tries to download OneDriveSetup.exe with the WebClient.

When those variables are changed to the same variables used by WebRequest (row 283) and Curl (row 288 & 293), "$DownloadUrl" & "$DownloadPath\$DownloadFile", the Download does work correctly.

WebClientError

@OSDeploy
Copy link
Owner

Can you test this using the latest OSD Module 22.1.11.2
image

@OSDeploy OSDeploy self-assigned this Jan 14, 2022
@OSDeploy OSDeploy added the bug Something isn't working label Jan 14, 2022
@NKK80
Copy link
Author

NKK80 commented Jan 17, 2022

image

Some additional information is that we are behind a proxy, because of this "Save-OSDBuilderDownload.ps1" will try to use the WebClient to download the OneDrive setup. And like I said in my original post the variables for the WebClient download of the OneDrive setup are empty.
I can change "Save-OSDBuilderDownload.ps1" myself to make the download work, but I would prefer it to work without that.

@NKK80
Copy link
Author

NKK80 commented Mar 11, 2022

Just tried to Download OneDriveEnterprise again, and the script still uses the same empty variables.
image

@OSDeploy
Copy link
Owner

OSDeploy commented Mar 14, 2022 via email

@jespinoza84
Copy link

Seeing this as well when running from Server 2016 v1607. Works fine when I run the same from my Windows 10 20H2 Workstation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants