Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Fix check for empty file when on python 2 #76

Merged
merged 2 commits into from
Jul 10, 2017

Conversation

betatim
Copy link
Member

@betatim betatim commented Jun 27, 2017

Fixes #75

In python 2 there is no peek(), so implemented our own.

Does someone know why six does not have a compatibility thing for this?

  • test the new function

@betatim
Copy link
Member Author

betatim commented Jun 27, 2017

The thing missing from this PR is a good idea how we could have caught this before. My unhappiness with the tests keeps growing :-/

@codecov-io
Copy link

codecov-io commented Jun 27, 2017

Codecov Report

Merging #76 into master will increase coverage by 0.08%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #76      +/-   ##
==========================================
+ Coverage    92.6%   92.68%   +0.08%     
==========================================
  Files          12       12              
  Lines         500      506       +6     
==========================================
+ Hits          463      469       +6     
  Misses         37       37
Impacted Files Coverage Δ
osfclient/utils.py 96.42% <100%> (+0.97%) ⬆️
osfclient/models/storage.py 94% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 374f57c...a61af93. Read the comment docs.

@betatim betatim merged commit e814f2a into osfclient:master Jul 10, 2017
@betatim betatim deleted the py2-file-peek branch July 10, 2017 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants