Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused dependency in org.eclipse.osgitech.rest #43

Closed
glatuske opened this issue Mar 20, 2024 · 8 comments
Closed

Unused dependency in org.eclipse.osgitech.rest #43

glatuske opened this issue Mar 20, 2024 · 8 comments
Assignees

Comments

@glatuske
Copy link

The pom.xml file of org.eclipse.osgitech.rest contains a non required/unused dependency to Apache Felix HTTP Jetty.

<dependency> <groupId>org.apache.felix</groupId> <artifactId>org.apache.felix.http.jetty</artifactId> </dependency>

We figured that out when running SBOM Maven plugin on it. The OSGi bundles does not have a dependency to Jetty or Felix HTTP, but the SBOM Maven plugin detects this dependency,

@maho7791
Copy link
Contributor

This dependency is needed for integration tests.

org.apache.felix.http.jetty;version='[5.0.4,5.0.5)',\

We will update the scope.

@maho7791 maho7791 self-assigned this Mar 20, 2024
@glatuske
Copy link
Author

Thanks a lot!

@glatuske
Copy link
Author

This dependency is needed for integration tests.

org.apache.felix.http.jetty;version='[5.0.4,5.0.5)',\

We will update the scope.

But could it just moved to the test plugin? I think in the implementation it's not required?

@maho7791
Copy link
Contributor

Sorry, the dependnecy is used to at compile scope in module:

org.eclipse.osgitech.rest.jetty

and for the tests

@maho7791
Copy link
Contributor

Its not only used in one integration test bundle, but in multiples

@glatuske
Copy link
Author

At least in org.eclipse.osgitech.rest itself it's not required ;-)

@maho7791
Copy link
Contributor

Got it ;-)

@glatuske
Copy link
Author

@maho7791 Would you create a release for this fix?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants