Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Split org.osgi.test.assertj into org.osgi.test.assertj.framework and org.osgi.test.assertj.promise #149

Closed
bjhargrave opened this issue Jun 26, 2020 · 2 comments · Fixed by #150
Assignees
Milestone

Comments

@bjhargrave
Copy link
Member

Having PromiseAssert in the bundle means all users must provide the promise/function packages. This is unfortunate in the OSGi compliance tests for those test which are not otherwise touching promise.

Since we may make more custom assertj asserts for other packages, we should probably have a unique artifacts for each package.

@bjhargrave bjhargrave self-assigned this Jun 26, 2020
@kriegfrj
Copy link
Contributor

One bundle per bundle or one per package?

@bjhargrave
Copy link
Member Author

Two artfacts: org.osgi.test.assertj.framework and org.osgi.test.assertj.promise for now.

If we do, for example, custom assertions for ConfigurationAdmin, we would then create a new artifact for that: org.osgi.test.assertj.cm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants