use internal index for EventType.byEventNumber instead of always crea… #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ting an array and iterating
|
seems good. can you confirm this doesn't affect the minimum jdk version? I always get a little confused around when you can use streams & lambdas and such, and this library is depended on by some pretty ooooollldd installs (unfortunately). |
|
What is the minimum jdk version? I assumed jdk 8 because of the 8 in the compiler plugin of the pom.xml file. I can run I also don't mind changing the Stream operations with a simple loop if you prefer that. |
|
jdk 8 is fine. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ting an array and iterating
This is a PR that avoids the EventType array allocation that I saw while creating the allocation profiles in #98