Set DefaultSSLSocketFactory to TLSv1.2 in line with JDK 11.0.11: #39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukestephenson-zendesk
approved these changes
Jun 15, 2021
There was a problem hiding this comment.
Potentially we want to update the version to reflect this could cause issues when upgrading.
https://github.com/osheroff/mysql-binlog-connector-java/blob/master/pom.xml#L7
|
Done, thanks Luke. |
|
oh. hmph. actually can you undo the version bump, please? I do that in the release. |
|
after that I will merge |
This reverts commit 84eaf6d.
|
@osheroff Thanks for that. I've just reverted the commit. |
|
@osheroff would you be able to publish a new release? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of JDK 11.0.11, TLS1.0 and TLS1.1 have been disabled by default. This change sets the default SSLSocketFactory to use TLSv1.2 to be consistent with JDK 11.0.11.
Reference for JDK 11.0.11: https://www.oracle.com/java/technologies/javase/11-0-11-relnotes.html#JDK-8202343