Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace code-assert with alternative checkstyle test #1797

Closed
dbwiddis opened this issue Nov 25, 2021 · 0 comments · Fixed by #1803
Closed

Replace code-assert with alternative checkstyle test #1797

dbwiddis opened this issue Nov 25, 2021 · 0 comments · Fixed by #1803
Labels
chore Lots of uninteresting small tasks design discussion Ways to improve OSHI's design maven dependencies An issue with unnecessary dependencies or competing transitive dependencies

Comments

@dbwiddis
Copy link
Member

dbwiddis commented Nov 25, 2021

I also think we should get rid of guru.nidi:code-assert alltogether as it has a humongous dependency tree and it's only used in one testcase:

Originally posted by @mprins in #1796 (comment)

The one testcase code-assert is used in is completely intended to give a runtime test enforcement of checkstyle issues. Prior to using this, we were only finding these issues in the Appveyor builds, and when I say "finding" I mean failing builds and spending 10 minutes poring over the log to try to figure out the issue, instead of having it print out nicely.

I'm okay with removing code-assert if we properly configure the checkstyle plugin to fail the build on warnings, see here, for example. Other potential options are using one of our existing CI integrations that integrates with PRs, or a Github Action that tests checkstyle, like this one

@dbwiddis dbwiddis added chore Lots of uninteresting small tasks design discussion Ways to improve OSHI's design PR welcome Not maintainer's priority to do but will accept contributions! up for grabs Issues the maintainers want community help with labels Nov 25, 2021
@dbwiddis dbwiddis added the maven dependencies An issue with unnecessary dependencies or competing transitive dependencies label Nov 25, 2021
@dbwiddis dbwiddis removed up for grabs Issues the maintainers want community help with PR welcome Not maintainer's priority to do but will accept contributions! labels Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Lots of uninteresting small tasks design discussion Ways to improve OSHI's design maven dependencies An issue with unnecessary dependencies or competing transitive dependencies
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant