Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure checkstyle, remove code-assert #1803

Merged
merged 4 commits into from Nov 29, 2021
Merged

Configure checkstyle, remove code-assert #1803

merged 4 commits into from Nov 29, 2021

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Nov 29, 2021 •
edited

Fixes #1797
Fixes #1799

@coveralls
Copy link

coveralls commented Nov 29, 2021 •
edited

Coverage Status

Coverage remained the same at 87.604% when pulling b818d63 on dbwiddis:checkstyle into 5a4fe48 on oshi:master.

@dbwiddis dbwiddis mentioned this pull request Nov 29, 2021
Closed
@dbwiddis
Copy link
Member Author

Well, that took way too long for a chore, but was a nice 6 hours of learning experience.

@dbwiddis dbwiddis merged commit 8c12323 into oshi:master Nov 29, 2021
@dbwiddis dbwiddis deleted the checkstyle branch November 29, 2021 16:46
dbwiddis added a commit that referenced this pull request Dec 15, 2021
@dbwiddis
Configure checkstyle, remove code-assert (#1803)
092b177 
* Configure checkstyle, remove code-assert

* Merge sun, google, and custom rules

* Import control rules, checkstyle fixes

* Codacy says I can do better at bash
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sonatype-lift sonatype-lift[bot] sonatype-lift left review comments

@hazendaz hazendaz hazendaz approved these changes

@mprins mprins mprins approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block imports not on module path Replace code-assert with alternative checkstyle test
4 participants
@dbwiddis @coveralls @hazendaz @mprins