New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DetectVM - Wrong comparison of result #908
Comments
Not only the MAC check, but the first MAC check. Looks like the error was introduced in #872. |
I'm marking this issue for first-timers-only. That means that I will only accept a PR for this one from someone who's never contributed to open source before. This one is easy (but don't make that statement make you feel bad if you have a hard time with it, there's more to contributing to open source than changing lines of code, especially if it's your first time). I'll hold your hand through this if you need me to. :-) Here are the steps to get a PR merged here.
|
Hi @dbwiddis. I haven't contributed to open source before and would like to give it a go. Do you mind if I contribute? |
Hi, sorry @shannondavid it looks like @yzhang2907 beat you to the punch here! I can suggest a slightly more challenging issue for you to work on if you'd still like to help! |
@dbwiddis I'd love to! |
@shannondavid check out #877. This comment covers the basics of what to do, scroll down to the end for the better Windows solution using event log. |
Fixed in #909 |
got it! checking out #877 now |
* Fixed issue 908, now empty string also checked. * Fixed issue 908, now empty string also checked. * Update DetectVM.java
In the class DetectVM (package oshi.demo), the method findOuiByMacAddressIfPossible returns an empty string if no entry was found in the vmMacAddressOUI map. However, the result is checked to null (not empty String), which means that the method always ends after the MAC address check.
The text was updated successfully, but these errors were encountered: