-
-
Notifications
You must be signed in to change notification settings - Fork 862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Physical memory additional information implementation #1005
Physical memory additional information implementation #1005
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1005 +/- ##
============================================
+ Coverage 77.43% 77.78% +0.34%
Complexity 2 2
============================================
Files 24 25 +1
Lines 1210 1229 +19
Branches 155 155
============================================
+ Hits 937 956 +19
Misses 206 206
Partials 67 67
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks really good so far. I've made some extremely minor comments/preferences.
oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsGlobalMemory.java
Outdated
Show resolved
Hide resolved
oshi-core/src/main/java/oshi/hardware/platform/windows/WindowsGlobalMemory.java
Outdated
Show resolved
Hide resolved
toString changes
memory for linux,max,etc.) and remove unused imports
…emory-speed-implementation
I've done the mac and Unix implementations. Can you review/test my changes? |
…emory-speed-implementation
Fixes #419