Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physical memory additional information implementation #1005

Merged
merged 14 commits into from
Oct 17, 2019
Merged

Physical memory additional information implementation #1005

merged 14 commits into from
Oct 17, 2019

Conversation

rohitkukreja1508
Copy link
Contributor

@rohitkukreja1508 rohitkukreja1508 commented Oct 2, 2019

Fixes #419

@coveralls
Copy link

coveralls commented Oct 2, 2019

Coverage Status

Coverage increased (+0.3%) to 81.53% when pulling d5288eb on rohitkukreja1508:Physical-memory-speed-implementation into 3fe6f09 on oshi:master.

@codecov-io
Copy link

codecov-io commented Oct 2, 2019

Codecov Report

Merging #1005 into master will increase coverage by 0.34%.
The diff coverage is 100%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1005      +/-   ##
============================================
+ Coverage     77.43%   77.78%   +0.34%     
  Complexity        2        2              
============================================
  Files            24       25       +1     
  Lines          1210     1229      +19     
  Branches        155      155              
============================================
+ Hits            937      956      +19     
  Misses          206      206              
  Partials         67       67
Impacted Files Coverage Δ Complexity Δ
oshi-core/src/main/java/oshi/util/ParseUtil.java 94.88% <ø> (ø) 0 <0> (ø) ⬇️
...re/src/main/java/oshi/hardware/PhysicalMemory.java 100% <100%> (ø) 0 <0> (?)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3fe6f09...d5288eb. Read the comment docs.

Copy link
Member

@dbwiddis dbwiddis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good so far. I've made some extremely minor comments/preferences.

@dbwiddis
Copy link
Member

I've done the mac and Unix implementations. Can you review/test my changes?

@oshi oshi deleted a comment Oct 14, 2019
@dbwiddis dbwiddis merged commit ba50a70 into oshi:master Oct 17, 2019
@rohitkukreja1508 rohitkukreja1508 deleted the Physical-memory-speed-implementation branch March 14, 2020 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory speed
4 participants