Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disk and Network method performance and thread safety #1107

Merged
merged 4 commits into from Feb 15, 2020
Merged

Disk and Network method performance and thread safety #1107

merged 4 commits into from Feb 15, 2020

Conversation

dbwiddis
Copy link
Member

@dbwiddis dbwiddis commented Feb 14, 2020

Fixes #1106

@dbwiddis dbwiddis linked an issue Feb 14, 2020 that may be closed by this pull request
@coveralls
Copy link

coveralls commented Feb 14, 2020

Coverage Status

Coverage remained the same at 78.838% when pulling f4fb5c5 on dbwiddis:threadsafe into 0cee9ab on oshi:master.

@codecov-io
Copy link

codecov-io commented Feb 14, 2020

Codecov Report

Merging #1107 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1107      +/-   ##
============================================
- Coverage     74.72%   74.66%   -0.06%     
  Complexity        2        2              
============================================
  Files            27       27              
  Lines          1341     1342       +1     
  Branches        169      170       +1     
============================================
  Hits           1002     1002              
- Misses          262      263       +1     
  Partials         77       77
Impacted Files Coverage Δ Complexity Δ
...i-demo/src/main/java/oshi/demo/OshiHTTPServer.java 0% <0%> (ø) 0% <0%> (ø) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0cee9ab...f4fb5c5. Read the comment docs.

@dbwiddis dbwiddis merged commit 286543a into oshi:master Feb 15, 2020
@dbwiddis dbwiddis deleted the threadsafe branch February 20, 2020 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Static maps are inefficient and possibly not thread safe
3 participants