Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Windows FileStore updating #1139

Merged
merged 2 commits into from
Mar 17, 2020
Merged

Fix Windows FileStore updating #1139

merged 2 commits into from
Mar 17, 2020

Conversation

dbwiddis
Copy link
Member

Fixes #1138

@coveralls
Copy link

coveralls commented Mar 17, 2020

Coverage Status

Coverage remained the same at 79.206% when pulling ba19729 on dbwiddis:winfsbug into 480117c on oshi:master.

@codecov
Copy link

codecov bot commented Mar 17, 2020

Codecov Report

Merging #1139 into master will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1139      +/-   ##
============================================
+ Coverage     75.16%   75.21%   +0.05%     
  Complexity        2        2              
============================================
  Files            31       31              
  Lines          1385     1384       -1     
  Branches        170      169       -1     
============================================
  Hits           1041     1041              
+ Misses          267      266       -1     
  Partials         77       77              
Impacted Files Coverage Δ Complexity Δ
...i-demo/src/main/java/oshi/demo/OshiHTTPServer.java 0.00% <0.00%> (ø) 0.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 30ded81...ba19729. Read the comment docs.

@dbwiddis dbwiddis merged commit 906e165 into oshi:master Mar 17, 2020
@dbwiddis dbwiddis deleted the winfsbug branch March 17, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSFileStore.updateAtrributes() always return false on windows
2 participants