CPU temperature, fan speeds, and voltage #121
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
|
|
||
| private JsonBuilderFactory jsonFactory = Json.createBuilderFactory(null); | ||
|
|
||
| private static final String HWMON = "/sys/class/hwmon/hwmon0/"; |
There was a problem hiding this comment.
The final number after hwmon indexes different sensors. hwmon0 may be temp and hwmon1 may be fans, or they may be in a different order. This needs rewriting to account for temp__input and fan__input being in any potential hwmon* path.
|
Hope to see some of this CoreFoundation stuff in JNA proper sometime ;) |
|
Maybe sometime. There's a difference between "write what you need" and "write the entire library and develop test cases for it" :) |
dbwiddis
changed the title
dbwiddis
changed the title
dbwiddis
added a commit
that referenced
this pull request
Mar 2, 2016
CPU temperature, fan speeds, and voltage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OS X and Linux CPU temperature and fan speeds for #119