Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor PerfCounterQuery classes and fix memory leak #1245

Merged
merged 1 commit into from May 30, 2020
Merged

Refactor PerfCounterQuery classes and fix memory leak #1245

merged 1 commit into from May 30, 2020

Conversation

dbwiddis
Copy link
Member

Fixes #1244

@coveralls
Copy link

coveralls commented May 30, 2020

Coverage Status

Coverage remained the same at 88.398% when pulling 193bd6c on dbwiddis:memleak into 92ca9b8 on oshi:master.

@codecov
Copy link

codecov bot commented May 30, 2020

Codecov Report

Merging #1245 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #1245   +/-   ##
=========================================
  Coverage     85.85%   85.85%           
  Complexity      279      279           
=========================================
  Files            25       25           
  Lines           905      905           
  Branches        124      124           
=========================================
  Hits            777      777           
  Misses           73       73           
  Partials         55       55           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 92ca9b8...193bd6c. Read the comment docs.

@dbwiddis dbwiddis merged commit 19c12f0 into oshi:master May 30, 2020
@dbwiddis dbwiddis deleted the memleak branch May 30, 2020 23:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Memory leak in PerfCounterQueryHandler constructor
2 participants