Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AIX port #1282

Merged
merged 103 commits into from
Jul 7, 2020
Merged

AIX port #1282

merged 103 commits into from
Jul 7, 2020

Conversation

dbwiddis
Copy link
Member

Fixes #1166

@tausiflife
Copy link
Collaborator

Added few things for process. Haven't been able to test it yet.
An observation -
For process count, i think i will just query ps again to list process and count them. But if we do so as we have done for other OS, this might give inconsistent results. Lets says if in between the calls to getProcesses and getProcessCount or vice-versa, some process get killed, the output will be inconsistent.

@dbwiddis
Copy link
Member Author

Looking good. I don't see a problem with process count being different between queries, a user should expect that. I think I prefer counting numeric filenames in proc (same code as in Linux, and in fact it's working as-is) to a command line ps call.

@tausiflife
Copy link
Collaborator

ohh and btw you don't have to source .bashrc again. its fixed :)

@dbwiddis
Copy link
Member Author

ohh and btw you don't have to source .bashrc again. its fixed :)

Thank you! I was just about to ask what you did and then wondered, did I ever chmod it to be executable? Was that the problem?

@tausiflife
Copy link
Collaborator

ohh and btw you don't have to source .bashrc again. its fixed :)

Thank you! I was just about to ask what you did and then wondered, did I ever chmod it to be executable? Was that the problem?

i don't think executable rights was the problem. What i found was that it never ran the .bashrc file. I just created a .bash_profile and added the code to source .bashrc. You could remove the code from .bashrc and add it to .bash_profile

@tausiflife
Copy link
Collaborator

As i now see the thread details in ps doesn't have values. I guess it just inherits them from the parent process.
image

Do you know any other way of finding thread details?

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.5%) to 87.927% when pulling 428302a on dbwiddis:aix into f3e57c2 on oshi:master.

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #1282 into master will decrease coverage by 0.91%.
The diff coverage is 60.71%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master    #1282      +/-   ##
============================================
- Coverage     85.93%   85.01%   -0.92%     
- Complexity      280      288       +8     
============================================
  Files            25       25              
  Lines           910      941      +31     
  Branches        124      134      +10     
============================================
+ Hits            782      800      +18     
- Misses           73       80       +7     
- Partials         55       61       +6     
Impacted Files Coverage Δ Complexity Δ
oshi-core/src/main/java/oshi/SystemInfo.java 44.44% <0.00%> (-5.56%) 7.00 <0.00> (ø)
oshi-core/src/main/java/oshi/util/FileUtil.java 60.49% <50.00%> (+1.28%) 20.00 <2.00> (+2.00)
.../src/main/java/oshi/hardware/CentralProcessor.java 80.00% <63.63%> (-6.25%) 0.00 <0.00> (ø)
oshi-core/src/main/java/oshi/util/ParseUtil.java 93.27% <90.90%> (-0.09%) 123.00 <4.00> (+6.00) ⬇️
oshi-core/src/main/java/oshi/PlatformEnum.java 100.00% <100.00%> (ø) 1.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 07375bf...dca83db. Read the comment docs.

@dbwiddis dbwiddis merged commit fa54ad6 into oshi:master Jul 7, 2020
@dbwiddis dbwiddis deleted the aix branch July 7, 2020 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

AIX UNIX ppc64 7 or higher support
3 participants