Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use lshw as backup for max CPU frequency #1298

Merged
merged 3 commits into from
Jul 14, 2020
Merged

Use lshw as backup for max CPU frequency #1298

merged 3 commits into from
Jul 14, 2020

Conversation

dbwiddis
Copy link
Member

Fixes #1297

@dbwiddis dbwiddis mentioned this pull request Jul 14, 2020
Closed
@coveralls
Copy link

coveralls commented Jul 14, 2020 •
edited

Coverage Status

Coverage remained the same at 88.098% when pulling d8becf1 on dbwiddis:maxfreq into d3d8f8d on oshi:master.

@Szwendacz99
Copy link
Contributor

Szwendacz99 commented Jul 14, 2020 •
edited

Lshw.queryCpuCapacity() returns unproper value so sth still wrong
probably because lshw returns good value only with root access

@dbwiddis
Copy link
Member Author

Well, I just set it to query current first, then max, and if any current is higher it'll use that.

Pretty sure that makes the test meaningless, but at least you should get a max equal to or greater than your max current.

@dbwiddis dbwiddis merged commit f7d09d7 into oshi:master Jul 14, 2020
@dbwiddis dbwiddis deleted the maxfreq branch July 14, 2020 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Linux max cpu frequency assumes intel processors
3 participants
@dbwiddis @coveralls @Szwendacz99