New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Passes default locale setting when executing commands. #1353
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. This works but I've left some comments on improving it.
Can you also add a change log entry under 5.3.0?
Maybe helper method? private static String[] getDefaultEnv() {
if (platform == PlatformEnum.WINDOWS) {
return ENVP_WINDOWS;
} else if (platform != PlatformEnum.UNKNOWN) {
return ENVP_UNIX;
} else {
return null;
}
} |
In the direction I was thinking but this will not change during operation, so we just need a one-time constant (So using this helper method but defining a constant as the result would work). |
Pushed review fixes. |
Ops, haven't seen your comment about changelog, adding it. |
eae81a4
to
6be39a1
Compare
@dbwiddis updated changelog and rebased. |
This looks good! I'm headed to bed but will get this merged tomorrow. Thanks for your contribution! |
Closes #1347
Passes locale when executing commands on different platforms.