Replace ps argument lists with enum #1675
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thinking more on this... I don't like the use of |
# Conflicts: # CHANGELOG.md
dbwiddis
added a commit
that referenced
this pull request
Jul 18, 2021
* Replace ps argument lists with enum * Replace arrays from split with enumMap * Only need to check if last enum is populated * OpenBSD update to use enummap (and same typo fix on context switches) * AIX update to use enummap (and typo fix on state) * Solaris update to use enummap * FreeBSD Threads using enummap * OpenBSD Threads * Solaris Threads * AIX Threads, prep debug output for testing * Handle consecutive delimiters * Solaris ps doesn't have system time * Remove debug testing * Remove unneeded subtraction by constant 0 * Changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I really like this improvement for ps argument lists. Much less error prone. FreeBSD processes done, will do for other *nix PS lists for processes and threads.
@basil what do you think?